Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/Semi-obvious/5.3?] Fix compilation error in hppa-tdep.c
Date: Wed, 30 Oct 2002 00:06:00 -0000	[thread overview]
Message-ID: <20021030080837.GY903@gnat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

I guess there was a slight improvement in the profile of
find_function_in_inferior. This causes a compilation failure on HP/UX.

As I was working on this file, I noticed a warning saying that we should
an extra pair of braces around the "&" expression, to avoid any
confusion. So I added it. I sometimes make silly mistakes, so I would
appreciate if somebody had a quick look, to make sure I did not screw
up.

This also gives me the opportunity to announce that the HP/UX target
is important for ACT, and that we will do the work necessary to keep
this port in good shape. My first goal for this platform is to make it
at least multiarch partial.

2002-10-30  Joel Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (find_function_in_inferior): Fix the declaration
        that caused a compilation error on HP/UX.
        (low_text_segment_addres): Fix a compilation warning.

Ok to apply?

Also, I am not sure about the 5.3 branch, I haven't pulled the sources
from this branch yet. But I will check this shortly and apply the fix
there if necessary (provided the change is approved, naturally).

Thanks,
-- 
Joel

[-- Attachment #2: hppa-tdep.c.diff --]
[-- Type: text/plain, Size: 1536 bytes --]

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.28
diff -c -3 -p -r1.28 hppa-tdep.c
*** hppa-tdep.c	24 Oct 2002 21:02:53 -0000	1.28
--- hppa-tdep.c	30 Oct 2002 07:57:35 -0000
*************** extern int hp_som_som_object_present;
*** 150,156 ****
  extern int exception_catchpoints_are_fragile;
  
  /* This is defined in valops.c. */
! extern struct value *find_function_in_inferior (char *);
  
  /* Should call_function allocate stack space for a struct return?  */
  int
--- 150,156 ----
  extern int exception_catchpoints_are_fragile;
  
  /* This is defined in valops.c. */
! extern struct value *find_function_in_inferior (const char *);
  
  /* Should call_function allocate stack space for a struct return?  */
  int
*************** static CORE_ADDR low_text_segment_addres
*** 300,306 ****
  static void
  record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
  {
!   if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)
         == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
        && section->vma < low_text_segment_address)
      low_text_segment_address = section->vma;
--- 300,306 ----
  static void
  record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
  {
!   if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
         == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
        && section->vma < low_text_segment_address)
      low_text_segment_address = section->vma;

             reply	other threads:[~2002-10-30  8:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-30  0:06 Joel Brobecker [this message]
2002-10-30  0:26 ` Joel Brobecker
2002-10-30  6:10   ` Daniel Jacobowitz
2002-10-30 13:09     ` Joel Brobecker
2002-10-31  7:13   ` Elena Zannoni
2002-10-31 15:46     ` Joel Brobecker
2002-10-30  6:42 ` Daniel Jacobowitz
2002-10-31  9:32   ` Andrew Cagney
2002-10-31  9:35     ` Daniel Jacobowitz
2002-10-31 13:10       ` Daniel Jacobowitz
2002-10-31 13:18         ` Andrew Cagney
2002-11-05 13:36           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021030080837.GY903@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox