From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20209 invoked by alias); 26 Oct 2002 14:41:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20022 invoked from network); 26 Oct 2002 14:41:43 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by sources.redhat.com with SMTP; 26 Oct 2002 14:41:43 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g9QEff8M000306 for ; Sat, 26 Oct 2002 16:41:41 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id g9QEffZi004412 for ; Sat, 26 Oct 2002 16:41:41 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id g9QEff6t004409; Sat, 26 Oct 2002 16:41:41 +0200 (CEST) Date: Sat, 26 Oct 2002 07:41:00 -0000 Message-Id: <200210261441.g9QEff6t004409@elgar.kettenis.dyndns.org> From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH] Address FIXME in i386-tdep.c:i386_extract_struct_value_address X-SW-Source: 2002-10/txt/msg00563.txt.bz2 We know for sure here that we're not dealing with a cooked register. Checked in. Mark Index: ChangeLog from Mark Kettenis * i386-tdep.c (i386_extract_struct_value_address): Use regcache_raw_read_unsigned instead of regcache_cooked_read_unsigned since we know that the register we're reading isn't a pseudo register. Rename variable 'val' into the more descriptive 'addr'. Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.88 diff -u -p -r1.88 i386-tdep.c --- i386-tdep.c 17 Sep 2002 20:42:01 -0000 1.88 +++ i386-tdep.c 26 Oct 2002 14:39:42 -0000 @@ -1039,25 +1039,17 @@ i386_store_return_value (struct type *ty } } -/* Extract from an array REGBUF containing the (raw) register state - the address in which a function should return its structure value, - as a CORE_ADDR. */ +/* Extract from REGCACHE, which contains the (raw) register state, the + address in which a function should return its structure value, as a + CORE_ADDR. */ static CORE_ADDR i386_extract_struct_value_address (struct regcache *regcache) { - /* NOTE: cagney/2002-08-12: Replaced a call to - regcache_raw_read_as_address() with a call to - regcache_cooked_read_unsigned(). The old, ...as_address function - was eventually calling extract_unsigned_integer (via - extract_address) to unpack the registers value. The below is - doing an unsigned extract so that it is functionally equivalent. - The read needs to be cooked as, otherwise, it will never - correctly return the value of a register in the [NUM_REGS - .. NUM_REGS+NUM_PSEUDO_REGS) range. */ - ULONGEST val; - regcache_cooked_read_unsigned (regcache, LOW_RETURN_REGNUM, &val); - return val; + ULONGEST addr; + + regcache_raw_read_unsigned (regcache, LOW_RETURN_REGNUM, &addr); + return addr; }