Re: [patch] useless code in symtab.c

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Oct 23, 2002 at 04:29:05PM -0700, David Carlton wrote:
> On Wed, 23 Oct 2002 18:54:13 -0400, Elena Zannoni <ezannoni@redhat.com> said:
> 
> > David Carlton writes:
> >> On Wed, 23 Oct 2002 18:32:32 -0400, Elena Zannoni <ezannoni@redhat.com> said:
> 
> >>> Can you also knock out the one at:
> 
> >>> linespec.c:38:extern char *find_template_name_end (char *);
> 
> >> That one gets used by decode_line_1.  (One of these days, I'll try
> >> to understand what that function is doing, but I'm not feeling
> >> quite that masochistic yet.)  Though I don't see any compelling
> >> reason not to just #include "parser-defs.h" there instead of
> >> declaring that one function specially; should I go ahead and do
> >> that?
> 
> > decode_line_1, I think it will also make coffee if you ask
> > nicely.... :-(
> 
> I really will have to give it a look; refactoring lookup_symbol_aux
> was fairly pleasant and has turned out to be quite useful for me, so
> at some point I'll see if decode_line_1 is amenable to a similar
> treament.  Probably not, though: lookup_symbol_aux breaks fairly
> neatly into a few decent-sized chunks, whereas decode_line_1 is a good
> deal longer (770 lines as opposed to 370) and seems to me, upon a
> brief skim, to not want to break apart nearly as nicely.

I admit (blasphemy!) I'm strongly considering declaring it dead, and
rewriting it to meet a proper specification.  This means coming up with
one first though, so it's a little bit down my list.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer