From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22641 invoked by alias); 23 Oct 2002 20:10:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22634 invoked from network); 23 Oct 2002 20:10:54 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 23 Oct 2002 20:10:54 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 184Slm-0007M6-00; Wed, 23 Oct 2002 16:10:26 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 184RqU-00086u-00; Wed, 23 Oct 2002 16:11:14 -0400 Date: Wed, 23 Oct 2002 13:10:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Michael Snyder , Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. Message-ID: <20021023201113.GA22053@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Michael Snyder , Adam Fedor , gdb-patches@sources.redhat.com References: <3D889A97.90202@doc.com> <3DA37857.466240D9@redhat.com> <3DB4811E.5080106@redhat.com> <3DB6F744.410DB743@redhat.com> <3DB6FA28.1080304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DB6FA28.1080304@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00474.txt.bz2 On Wed, Oct 23, 2002 at 03:36:08PM -0400, Andrew Cagney wrote: > >> > > > >>> - error ("no args, no `this'"); > > > >>>> + error ("no args, no %s", name); > > > >> > >>Michael, > >> > >>This changes GDB's behavior. Instead of printing: > >> > >> no args, no `this' > >>it will print > >> no args, no this > >> > >>I don't think GDB's output should be changed in this way. > >>(I'm suprized that running the testsuite didn't detect this). > > > > > >Hi Andrew, > > > >I corrected this with the patch below. I did not add a new test, > >because I cannot find a way to invoke this error message. ;-/ > > Michael, my memory of the Apple patch is that it changed this > everywhere, the above was just one example :-( (btw `this' not 'this'). By the way, GCC recently reached the consensus that '' and "" were appropriate quote marks, and that `' should go away. [Although I think they also decided that `' should be left in the source and transliterated by the output routines; that way we can generate proper quotes in locales which have them. Or maybe that the real Unicode quotes should be used in source and transliterated to ''.] -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer