Re: [RFA] Use vfork in shell_escape

Andrew Cagney
2002-10-22T21:43:30Z

> Daniel Jacobowitz wrote:
>
>>
>> On Tue, Oct 22, 2002 at 01:54:01PM -0700, Michael Snyder wrote:
>
>> > Daniel Jacobowitz wrote:
>
>> > >
>> > > This patch is pretty obvious. I couldn't figure out why my machine was
>> > > running out of memory; forking GDB to run an 'ls' during the maint.exp tests
>> > > can be a bit heavy, since it may have all of glibc's debug info loaded.
>> > > This patch seems logical to me... OK to commit?
>
>> >
>> > Not as is. There's some auto-confery involved, since many systems
>> > (some systems?) don't have vfork. Grep for vfork in fork-child.c.
>
>>
>> Not as much as there used to be. But you're right, I goofed. OK with
>> the addition of '#include "gdb_vfork.h"', which is all fork-child.c
>> uses now?
>
>
> For all I know, that's OK -- but I don't know.
> I'll step back now, and wait for someone who does.

Yep, from the ARI:

HAVE VFORK #ifdef HAVE_VFORK is redundant. Include "gdb_vfork.h" and
call vfork() unconditionally.

Fernando - CLI?

Andrew