Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Cc: fnasser@redhat.com
Subject: [RFA] Use vfork in shell_escape
Date: Mon, 21 Oct 2002 18:51:00 -0000	[thread overview]
Message-ID: <20021022015205.GA22323@nevyn.them.org> (raw)

This patch is pretty obvious.  I couldn't figure out why my machine was
running out of memory; forking GDB to run an 'ls' during the maint.exp tests
can be a bit heavy, since it may have all of glibc's debug info loaded. 
This patch seems logical to me... OK to commit?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2002-10-21  Daniel Jacobowitz  <drow@mvista.com>

	* cli/cli-cmds.c (shell_escape): Use vfork.

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.22
diff -u -p -r1.22 cli-cmds.c
--- cli/cli-cmds.c	22 Sep 2002 22:18:41 -0000	1.22
+++ cli/cli-cmds.c	22 Oct 2002 01:47:15 -0000
@@ -517,7 +517,7 @@ shell_escape (char *arg, int from_tty)
   else
     p++;			/* Get past '/' */
 
-  if ((pid = fork ()) == 0)
+  if ((pid = vfork ()) == 0)
     {
       if (!arg)
 	execl (user_shell, p, 0);


             reply	other threads:[~2002-10-22  1:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-21 18:51 Daniel Jacobowitz [this message]
2002-10-22 13:54 ` Michael Snyder
2002-10-22 13:56   ` Daniel Jacobowitz
2002-10-22 14:00     ` Michael Snyder
2002-10-22 14:43       ` Andrew Cagney
2002-10-22 14:59         ` Elena Zannoni
2002-11-05 13:43 ` Daniel Jacobowitz
2003-06-21 18:39   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021022015205.GA22323@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox