Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Klee Dienes <klee@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] minor nit in read_tilde_fields
Date: Wed, 16 Oct 2002 06:54:00 -0000	[thread overview]
Message-ID: <20021016135357.GA26410@nevyn.them.org> (raw)
In-Reply-To: <1F507DC8-E0F2-11D6-B237-00039396EEB8@apple.com>

You're right, please commit this.  Not sure how this didn't show up in
my testing...

On Wed, Oct 16, 2002 at 06:29:16AM -0400, Klee Dienes wrote:
> The following patch fixes what I suspect is an "oops" in the 2002-10-11 
> patch to stabsread.c:
> 
> 2002-10-16  Klee Dienes  <kdienes@apple.com>
> 
>         * stabsread.c (read_tilde_fields): Use name[sizeof(vptr_name)-2]
>         to get the last character of a char[] buffer, not
>         name[sizeof(vptr_name)-1].
> 
> diff -u -r1.21 stabsread.c
> --- stabsread.c 2002/10/12 18:23:58     1.21
> +++ stabsread.c 2002/10/16 10:29:05
> @@ -4189,7 +4189,7 @@
>                 {
>                   char *name = TYPE_FIELD_NAME (t, i);
>                   if (!strncmp (name, vptr_name, sizeof (vptr_name) - 2)
> -                     && is_cplus_marker (name[sizeof (vptr_name) - 1]))
> +                     && is_cplus_marker (name[sizeof (vptr_name) - 2]))
>                     {
>                       TYPE_VPTR_FIELDNO (type) = i;
>                       goto gotit;
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-10-16 13:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-04 19:53 [PATCH] Redefine skip_quoted Adam Fedor
2002-10-08 16:22 ` Michael Snyder
2002-10-14 13:47   ` Jim Blandy
2002-10-14 14:30     ` Michael Snyder
2002-10-14 14:33     ` Klee Dienes
2002-10-16  0:44       ` Jim Blandy
2002-10-16  3:29         ` [PATCH] minor nit in read_tilde_fields Klee Dienes
2002-10-16  6:54           ` Daniel Jacobowitz [this message]
2002-10-17 23:33         ` [PATCH] Redefine skip_quoted Adam Fedor
2002-10-18 14:52           ` Elena Zannoni
2002-10-18 15:54             ` Adam Fedor
2002-10-22  8:04               ` Elena Zannoni
2002-10-25 12:43                 ` Adam Fedor
2002-11-03 16:20                   ` Elena Zannoni
2002-11-03 18:54                     ` GDB ObjC plan (was: Re: [PATCH] Redefine skip_quoted) Adam Fedor
2002-11-07 12:36               ` [PATCH] Redefine skip_quoted Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021016135357.GA26410@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=klee@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox