From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11883 invoked by alias); 10 Oct 2002 20:39:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11868 invoked from network); 10 Oct 2002 20:39:57 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 10 Oct 2002 20:39:57 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17zl1u-0006ze-00; Thu, 10 Oct 2002 16:39:40 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17zk65-0006vv-00; Thu, 10 Oct 2002 16:39:53 -0400 Date: Thu, 10 Oct 2002 13:39:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: fnasser@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH RFA] New constvars.exp tests Message-ID: <20021010203953.GA26607@nevyn.them.org> Mail-Followup-To: Kevin Buettner , fnasser@redhat.com, gdb-patches@sources.redhat.com References: <1021010203259.ZM16308@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1021010203259.ZM16308@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00222.txt.bz2 On Thu, Oct 10, 2002 at 01:32:59PM -0700, Kevin Buettner wrote: > I am about to submit a patch which causes ptype to print a struct with > qualifiers correctly. E.g, for the "crass" test, gdb currently > exhibits the following behavior: > > (gdb) ptype crass > type = struct crass { > char * constptr; > } > > This is incorrect because gdb failed to print a space in between > "const" and "ptr". > > Unfortunately, if you don't use Dwarf 2, you'll simply end up seeing > > type = struct crass { > char *ptr; > } > > ...which is also wrong, but not unexpected (hence the xfail). Not necessarily. Recent versions of GCC will emit const qualifiers in stabs, leading to a horde of XPASS's in our testsuite... but that's a problem for another patch. Nice to see someone working on the type printer. I'm planning to submit a "hit it over the head with a board" patch in a couple of days, to let us simulate the output of the various demangling styles. > * gdb.base/constvars.c (struct crass, struct crisp): New structs. > * gdb.base/constvars.exp (ptype crass, ptype crisp): New tests. FWIW, these test cases look correct to me. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer