Re: [RFA] string_to_core_addr fix

Kevin Buettner
2002-10-11T07:08:32Z

On Oct 10, 9:29pm, Martin M. Hunt wrote:

> For years we used parse_and_eval_address() in Insight until earlier this year
> when those calls were replaced with string_to_core_addr(), breaking all mips
> targets. parse_and_eval_address() internally calls INTEGER_TO_ADDRESS() so I
> probably should use that. In fact I decided to just do what
> parse_and_eval_address() did but apparently submitted the wrong version.
>
> Revised patch attached.
>
> Index: utils.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/utils.c,v
> retrieving revision 1.80
> diff -u -p -r1.80 utils.c
> --- utils.c 20 Sep 2002 00:24:01 -0000 1.80
> +++ utils.c 11 Oct 2002 04:29:51 -0000
> @@ -2649,6 +2649,8 @@ string_to_core_addr (const char *my_stri
> internal_error (__FILE__, __LINE__, "invalid decimal");
> }
> }
> + if (INTEGER_TO_ADDRESS_P ())
> + addr = INTEGER_TO_ADDRESS (builtin_type_void_data_ptr, &addr);
> return addr;
> }

Okay, this version looks reasonable. (Approved.) Make sure you
update the ChangeLog entry to match.

Kevin