From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3282 invoked by alias); 4 Oct 2002 02:25:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3274 invoked from network); 4 Oct 2002 02:25:43 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 4 Oct 2002 02:25:43 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17xJ5n-0007R6-00 for ; Thu, 03 Oct 2002 22:25:31 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17xIAQ-0004S1-00 for ; Thu, 03 Oct 2002 22:26:14 -0400 Date: Thu, 03 Oct 2002 19:25:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH RFA] Create new file mips-tdep.h Message-ID: <20021004022613.GA16925@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <1021004010349.ZM32674@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1021004010349.ZM32674@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-10/txt/msg00121.txt.bz2 On Thu, Oct 03, 2002 at 06:03:49PM -0700, Kevin Buettner wrote: > I have some other changes under way in which I will need to know which > mips ABI is in use. I've moved struct gdbarch_tdep and the enums > that it depends upon into a new header file. > > Okay? I think this is a good idea, though of course you'll need to wait for Andrew - it may be some time, I believe. This patch reminded me of something. I don't really like the fact that we have a "struct gdbarch_tdep" for every architecture; when we have a multi-architecture GDB this will cause tremendous debugging confusion. How intrusive do you think it would be to opaquify it (I hope that's not really a word) properly, and have a struct mips_gdbarch_tdep? > > * Makefile.in (mips_tdep_h): Define. > (mips-tdep.o): Remove osabi_h from dependency list. Add mips_tdep_h > to dependency list. > * mips-tdep.h: New file. > * mips-tdep.c (mips-tdep.h): Include. > (osabi.h): Don't include (since it's included by mips-tdep.h). > (enum mips_abi, enum_mips_fpu_type, struct gdbarch_tdep): Move > definitions to mips-tdep.h. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer