From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27173 invoked by alias); 1 Oct 2002 03:17:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27154 invoked from network); 1 Oct 2002 03:17:54 -0000 Received: from unknown (HELO crushed.velvet.net) (62.49.231.23) by sources.redhat.com with SMTP; 1 Oct 2002 03:17:54 -0000 Received: from aidan by crushed.velvet.net with local (Exim 3.33 #1) id 17wDX7-0004gH-00; Tue, 01 Oct 2002 04:17:13 +0100 Date: Mon, 30 Sep 2002 20:17:00 -0000 From: Aidan Skinner To: Hilfinger@otisco.mckusick.com Cc: jimb@redhat.com, ac131313@redhat.com, aidan@velvet.net, drow@mvista.com, per@bothner.com, green@redhat.com, muller@cerbere.u-.strasbg.fr, gdb-patches@sources.redhat.com Subject: Re: [RFA] Add type support for Ada Message-ID: <20021001041712.E8933@velvet.net> References: <20020926040044.I32211@velvet.net> <3D93C161.2070409@redhat.com> <200209280925.CAA10025@otisco.McKusick.COM> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200209280925.CAA10025@otisco.McKusick.COM>; from hilfingr@otisco.mckusick.com on Sat, Sep 28, 2002 at 02:25:59AM -0700 X-SW-Source: 2002-09/txt/msg00794.txt.bz2 --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1597 On Sat, Sep 28, 2002 at 02:25:59AM -0700, Paul N. Hilfinger wrote Thanks for answering these Paul. :) > > It looks to me as if the string cleanup stuff is distinct from the > > fixed instance stuff. These should be submitted as separate patches. >=20 > They definitely are logically separate changes. Yeah, I'll split and resubmit and probably take the opportunity to include some more string cleanup stuff, rather than just the bits that ada-* reference... > > Should base_type use the tortoise-and-hare algorithm to detect cycles? >=20 > An interesting suggestion. However, there is at least one existing > place where GDB doesn't bother. Compare with the following (non-Ada- I think it's worthwhile doing here, and if it works nicely it can be stolen for other places. My next revision of this patch will include this. > Umm. Interesting questions. As I recall, I had the impression that=20 > a self-referencing range type COULD occur legitimately, but given that was I think they can, but my current understanding of the gdb type system probably bears some resemblence to swiss cheese. ;) I'll experiment a bit with trying to create one and see what I can find. > 4 years ago, my memory could be faulty. I suspect these tests were simply > bullet-(or segfault)-proofing. Replacing the NULL check at least with > an error would probably be a worthy experiment. Sounds like a plan. - Aidan --=20 aidan@velvet.net http://www.velvet.net/~aidan/ aim:aidans42 http://www.livejournal.com/users/aidan_skinner/ finger for pgp key: 01AA 1594 2DB0 09E3 B850 C2D0 9A2C 4CC9 3EC4 75E1 --nmemrqcdn5VTmUEE Content-Type: application/pgp-signature Content-Disposition: inline Content-length: 230 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (OpenBSD) Comment: For info see http://www.gnupg.org iD8DBQE9mROrmixMyT7EdeERAp+aAJoDHlNViKvLv+gMRY78zBAoNt1PQgCcCR/S gqHwmF5JxC1P5ZO9tfCuGXg= =LF+p -----END PGP SIGNATURE----- --nmemrqcdn5VTmUEE--