From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4626 invoked by alias); 18 Sep 2002 16:12:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4612 invoked from network); 18 Sep 2002 16:12:53 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Sep 2002 16:12:53 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8IFtgi11669 for ; Wed, 18 Sep 2002 11:55:42 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8IGCpx08638 for ; Wed, 18 Sep 2002 12:12:51 -0400 Received: from cygbert.vinschen.de (vpn50-15.rdu.redhat.com [172.16.50.15]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g8IGCnC22947 for ; Wed, 18 Sep 2002 09:12:49 -0700 Received: (from corinna@localhost) by cygbert.vinschen.de (8.11.6/8.9.3/Linux sendmail 8.9.3) id g8IGCk915412 for gdb-patches@sources.redhat.com; Wed, 18 Sep 2002 18:12:46 +0200 Date: Wed, 18 Sep 2002 09:12:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.base/ending-run.exp Message-ID: <20020918181246.D29920@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20020918132156.Z29920@cygbert.vinschen.de> <3D889F71.2070202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D889F71.2070202@redhat.com> User-Agent: Mutt/1.3.22.1i X-SW-Source: 2002-09/txt/msg00400.txt.bz2 On Wed, Sep 18, 2002 at 11:44:49AM -0400, Fernando Nasser wrote: > >Index: gdb.base/ending-run.exp > >=================================================================== > >RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v > >retrieving revision 1.16 > >diff -u -p -r1.16 ending-run.exp > >--- gdb.base/ending-run.exp 19 Jul 2002 00:02:34 -0000 1.16 > >+++ gdb.base/ending-run.exp 18 Sep 2002 11:21:22 -0000 > >@@ -195,7 +195,7 @@ gdb_expect { > > -re ".*in.*\\\$START\\\$.*from.*dld.sl.*$gdb_prompt $" { > > pass "step out of main" > > } > >- -re ".*in __wrap_main ().*$gdb_prompt $" { > >+ -re ".*in __wrap__?main ().*$gdb_prompt $" { > > pass "step out of main (status wrapper)" > > } > > -re ".*$gdb_prompt $" { fail "step out of main (at end 2)" } > > This part is OK. You can check it in immediately. Applied. > >@@ -245,8 +245,12 @@ if {! [target_info exists use_gdb_stub] > > # exit" message. > > pass "step to end of run" > > } > >- -re "Single.*EXIT code 0.*Program exited normally.*$gdb_prompt $" { > >+ -re "Single.*EXIT code 0\r\n.*Program exited normally.*$gdb_prompt $" > >{ > > pass "step to end of run (status wrapper)" > > You forgot to mention this change (which seems correct). It also can be > checked in providing you mention it in the ChangeLog. Applied w/ ChangeLog entry. > The code for xstormy was actually not correct. Please look at the > attached (untested) patch, add your case to it setting the variables > accordingly and give it a spin. If it works for you I will check it in > and then you can add the case above to it. Works fine. My code then adds the new case as unsupported. I'll check it in as soon as you checked your patch in. Thanks, Corinna