From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13847 invoked by alias); 16 Sep 2002 22:02:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13840 invoked from network); 16 Sep 2002 22:02:18 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 16 Sep 2002 22:02:18 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17r4sb-0002hj-00; Mon, 16 Sep 2002 18:02:09 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17r3wV-0008R9-00; Mon, 16 Sep 2002 18:02:07 -0400 Date: Mon, 16 Sep 2002 15:02:00 -0000 From: Daniel Jacobowitz To: Earl Chew Cc: gdb-patches@sources.redhat.com, cgf@redhat.com Subject: Re: [RFC PATCH] Finding files in source trees (was Re: Finding source files under Cygwin) Message-ID: <20020916220207.GA32278@nevyn.them.org> Mail-Followup-To: Earl Chew , gdb-patches@sources.redhat.com, cgf@redhat.com References: <3D82897C.81376AD6@agilent.com> <3D862BD0.A5298600@agilent.com> <3D864101.2A0BCA85@agilent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D864101.2A0BCA85@agilent.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-09/txt/msg00322.txt.bz2 On Mon, Sep 16, 2002 at 01:37:21PM -0700, Earl Chew wrote: > Christopher Faylor wrote: > > I'm sorry but it is rarely a good idea to mix functionality like this. > > You're mixing an (arguable) bug fix with an (arguable) gdb enhancement. > > > > Please submit each as a separate patch. > > Ok. This patch allows files to be found in source trees. > > The motivation for this addition is to accommodate large projects > where source files are scattered in large source trees. I want to > be able to point gdb at the root of the source tree, rather than have > to specify each leaf directory. Thus I can write: > > gdb> dir /myproject/source > > instead of: > > gdb> dir /myproject/source/a/b/c:/myproject/source/z/b/d: etc This patch needs a lot more testing before I'd be comfortable with it. We went to a fair amount of trouble to support finding the right file when multiple files have the same name. For instance, given: dir /a:/b filename foo/bar.c files /a/bar.c /b/foo/bar.c will your patch find /b/foo/bar.c? I don't think it will. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer