Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Finding source files under cygwin
Date: Mon, 16 Sep 2002 12:48:00 -0000	[thread overview]
Message-ID: <20020916194835.GC2600@redhat.com> (raw)
In-Reply-To: <3D862BD0.A5298600@agilent.com>

On Mon, Sep 16, 2002 at 12:06:56PM -0700, Earl Chew wrote:
>Christopher Faylor wrote:
>> >Another fix is to make source.c use ; (semicolon) as a path
>> >separator instead of : (colon) should HAVE_DOS_BASED_FILE_SYSTEM
>> >be true. The downside here is that it might be surprising
>> >to current cygwin users.
>> 
>> This one is out.  This would break backwards compatibility and would be
>> incompatible with the convention used in the rest of cygwin.
>> 
>> The simplest solution is to just compile your object files using
>> the /cygdrive/d/xxx/yyy/zzz syntax.  The ability to use this syntax
>> is one of the motivations for cygwin.
>> 
>> However, if you want to provide a patch for either open_source_file
>> or buildsym.c, I'll gladly review it.
>
>I've included a patch below for you to consider. In addition to
>robustly handling the presence of DIRNAME_SEPARATOR in the file
>names embedded in the object file, I've included a patch to allow
>files to be found in source trees.
>
>The motivation for this addition is to accommodate large projects
>where source files are scattered in large source trees. I want to
>be able to point gdb at the root of the source tree, rather than have
>to specify each leaf directory. Thus I can write:
>
>	gdb> dir /myproject/source
>
>instead of:
>
>	gdb> dir /myproject/source/a/b/c:/myproject/source/z/b/d: etc

I'm sorry but it is rarely a good idea to mix functionality like this.
You're mixing an (arguable) bug fix with an (arguable) gdb enhancement.

Please submit each as a separate patch.

cgf


  reply	other threads:[~2002-09-16 19:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-13 17:57 Finding source files under Cygwin Earl Chew
2002-09-13 21:40 ` Finding source files under cygwin Christopher Faylor
2002-09-16 12:07 ` Finding source files under Cygwin Earl Chew
2002-09-16 12:48   ` Christopher Faylor [this message]
2002-09-16 13:14   ` Earl Chew
2002-09-16 13:37   ` [RFC PATCH] Finding files in source trees (was Re: Finding source files under Cygwin) Earl Chew
2002-09-16 15:02     ` Daniel Jacobowitz
2002-09-16 15:17       ` Earl Chew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020916194835.GC2600@redhat.com \
    --to=cgf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox