From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8651 invoked by alias); 14 Sep 2002 15:45:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8630 invoked from network); 14 Sep 2002 15:45:42 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 14 Sep 2002 15:45:42 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17qG3E-0003qr-00 for ; Sat, 14 Sep 2002 11:45:44 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17qF7T-0002Uk-00 for ; Sat, 14 Sep 2002 11:46:03 -0400 Date: Sat, 14 Sep 2002 08:45:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix gdbtypes.c:check_stub_method_group. Message-ID: <20020914154603.GA9454@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200209141540.g8EFeNhZ039487@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200209141540.g8EFeNhZ039487@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-09/txt/msg00298.txt.bz2 Oops. Thank you, Mark. I need to stop testing in an -O0 tree (causing -Wuninitialized not to work, in 2.95 at least). On Sat, Sep 14, 2002 at 05:40:23PM +0200, Mark Kettenis wrote: > My compiler warns about it, and rigtly so. Checked in as obvious. > > Mark > > Index: ChangeLog > from Mark Kettenis > > * gdbtypes.c (check_stub_method_group): Initialize found_stub to > zero. > > Index: gdbtypes.c > =================================================================== > RCS file: /cvs/src/src/gdb/gdbtypes.c,v > retrieving revision 1.57 > diff -u -p -r1.57 gdbtypes.c > --- gdbtypes.c 14 Sep 2002 02:09:39 -0000 1.57 > +++ gdbtypes.c 14 Sep 2002 15:38:29 -0000 > @@ -1793,7 +1793,7 @@ check_stub_method_group (struct type *ty > { > int len = TYPE_FN_FIELDLIST_LENGTH (type, method_id); > struct fn_field *f = TYPE_FN_FIELDLIST1 (type, method_id); > - int j, found_stub; > + int j, found_stub = 0; > > for (j = 0; j < len; j++) > if (TYPE_FN_FIELD_STUB (f, j)) > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer