From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26111 invoked by alias); 13 Sep 2002 00:41:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26104 invoked from network); 13 Sep 2002 00:41:48 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 13 Sep 2002 00:41:48 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17pfSx-00012q-00; Thu, 12 Sep 2002 20:41:51 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17peX7-0005AS-00; Thu, 12 Sep 2002 20:42:05 -0400 Date: Thu, 12 Sep 2002 17:41:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [PATCH RFC] Character set support Message-ID: <20020913004205.GB19479@nevyn.them.org> Mail-Followup-To: Kevin Buettner , gdb-patches@sources.redhat.com, Jim Blandy References: <1020913003056.ZM15701@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1020913003056.ZM15701@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-09/txt/msg00231.txt.bz2 On Thu, Sep 12, 2002 at 05:30:56PM -0700, Kevin Buettner wrote: > Jim Blandy is the author of the patch below. I have looked it over > though and it looks reasonable to me. Also, I have tested Jim's work > and see no regressions nor any new failures as a result of the tests > that Jim has added. > > I have tried to think of ways to break these changes up so that they > may be committed it in smaller sections. With the exception of > possible separate commits for the documentation and testsuite > portions, I can't think of any further divisions which make sense. > > I'll wait a week for comments after which time, if there are no > objections, I'll commit it. Two comments: There's a lot of passing integers around to refer to a character. That doesn't make a lot of sense to me; we should either be passing char *, so that we can decode multibyte sequences, or using wchar_t explicitly and autoconfing for it. I see hardcoded support for a couple of simplistic charsets; would it be worthwhile to add (minimal!) support for UTF-8 in case iconv is not available? Gcj is natively UTF-8, and I have some open Debian bug reports about this. I flinch at the tables but they seem like the only reasonable approach. I've only skimmed the rest, but it looks reasonable to me. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer