From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24458 invoked by alias); 12 Sep 2002 19:06:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24449 invoked from network); 12 Sep 2002 19:06:28 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 12 Sep 2002 19:06:28 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id B2AF8D2CC1; Thu, 12 Sep 2002 12:06:25 -0700 (PDT) Date: Thu, 12 Sep 2002 12:06:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: usage of tab in the indentation... Message-ID: <20020912190625.GB1105@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2002-09/txt/msg00205.txt.bz2 I don't really know where to ask this question, but since this is bugging me in the GDB sources, I'll ask here. I looked at the GNU Coding Standards manual, and they give a list of recommendations on how GNU code should be formatted, but they don't mention tabulations. In the list of options to GNU indent that they give, they leave the choice of tabs or not to indent (ie they use the default, which is to use tabs): (http://www.gnu.org/prep/standards_23.html#SEC23). I personally find that tabs are a nuisance, what are the advantages of using tabs? So far, they make my editor insert cursor go sometimes "like crazy" but more importantly, they sometimes screw the diff output. Consider the following hunk: << --- 2071,2082 ---- if (target_is_remote ()) { if (args == 0 || *args == 0) ! { ! if (tracepoint_number == -1) ! error ("No current tracepoint -- please supply an argument."); ! else ! tdp = tracepoint_number; /* default is current TDP */ ! } else tdp = parse_and_eval_long (args); >> See how the left curly brace is misplaced because of the tab? Could we consider banning tabs in favor of spaces and add -nut to the list of indent options in gdb_indent.sh? (I am not trying to start a troll, ok? :-). -- Joel