Re: [PATCH] mips_extract_struct_return_value: use saved regcache

Andrew Cagney
2002-09-10T04:11:26Z

> ! mips_extract_struct_value_address (struct regcache *regcache)
> {
> /* FIXME: This will only work at random. The caller passes the
> struct_return address in V0, but it is not preserved. It may
> still be there, or this may be a random value. */
> ! CORE_ADDR val;
> ! regcache_cooked_read_unsigned (regcache, V0_REGNUM, &val);
> ! return val;
> }

FYI,

This should be regcache_cooked_read_signed() so that the address is sign
extended. I think val should also be a LONGEST.

Andrew