From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25478 invoked by alias); 22 Aug 2002 21:32:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25471 invoked from network); 22 Aug 2002 21:32:22 -0000 Received: from unknown (HELO tomago.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Aug 2002 21:32:22 -0000 Received: (from graces@localhost) by tomago.toronto.redhat.com (8.11.6/8.11.6) id g7MLWLw12727; Thu, 22 Aug 2002 17:32:21 -0400 Date: Thu, 22 Aug 2002 14:38:00 -0000 From: Grace Sainsbury To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: breakpoint error messages Message-ID: <20020822173220.A12466@tomago.toronto.redhat.com> References: <20020821142627.A10117@tomago.toronto.redhat.com> <3D655542.AF3065A0@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3D655542.AF3065A0@redhat.com>; from msnyder@redhat.com on Thu, Aug 22, 2002 at 02:18:58PM -0700 X-SW-Source: 2002-08/txt/msg00718.txt.bz2 On Thu, Aug 22, 2002 at 02:18:58PM -0700, Michael Snyder wrote: > Grace Sainsbury wrote: > > > > I changed insert_breakpoints to collect all the warning messages from > > failed inserts and print them with an error after trying the whole > > queue. This changes the functionality slightly -- the old code stopped > > after the first failed insert of a breakpoint. I also changed the > > error messages to be more explicit about hardware breakpoints. > > > > ok? > > Grace, thanks for the contribution. A few implementation details. > First off, you've lost some output. > 1) The word "Warning: ", which is generated by the 'warning' function > (which you've replaced by fprintf_unfiltered). One instance would > probably be enough. ok. > 2) The output of the 'memory_error' function. The original purpose of the change was to remove that text 'Cannot access memory address XXXXX' doesn't seem to be meaningful in this context. > 3) The msg "The same program may be running in another process" I'll add that back. > 4) The output of print_sys_errmsg, formerly called by infrun. This printed 'Unknown error' which seems to be uninformative. > > Do you think you could work those back in? > > Then, just some textual edits. In one comment you say > "If there wat an error", where you probably meant to say 'was'. > And there's this: > if (hw_breakpoint_error) > fprintf_unfiltered (tmp_error_stream, > "Could not insert breakpoints: ..." > > Seems like you might as well say "hardware breakpoints" there. ok. let me know if you really want the memory_error, print_sys_errmsg text back. thanks, grace