From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5275 invoked by alias); 18 Aug 2002 20:19:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5268 invoked from network); 18 Aug 2002 20:19:24 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by sources.redhat.com with SMTP; 18 Aug 2002 20:19:24 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7IKJGnc000274; Sun, 18 Aug 2002 22:19:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7IKJG47000328; Sun, 18 Aug 2002 22:19:16 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7IKJGLp000325; Sun, 18 Aug 2002 22:19:16 +0200 (CEST) Date: Sun, 18 Aug 2002 13:19:00 -0000 Message-Id: <200208182019.g7IKJGLp000325@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ac131313@ges.redhat.com CC: ac131313@ges.redhat.com, gdb-patches@sources.redhat.com In-reply-to: <3D5FFEA6.9000306@ges.redhat.com> (message from Andrew Cagney on Sun, 18 Aug 2002 16:08:06 -0400) Subject: Re: [PATCH] Remove some write_register_bytes occurences from i386-tdep.c References: <200208181718.g7IHIrg6029437@elgar.kettenis.dyndns.org> <3D5FDD69.7000102@ges.redhat.com> <3D5FFEA6.9000306@ges.redhat.com> X-SW-Source: 2002-08/txt/msg00525.txt.bz2 Date: Sun, 18 Aug 2002 16:08:06 -0400 From: Andrew Cagney > As for write_register_bytes() can it be avoided? I've just posted ``regcache_cooked_write_with_offset_hack(). But I don't think that hack is right here. Perhaphs a single register read - modify - write function is needed? Hmm, I just hit a need for the same operation while implementing some pseudo registers. Just adding: regcache_raw_read_part(regcache,regnum,offset,length,buf) regcache_raw_write_part(regcache,regnum,offset,length,buf) Where OFFSET would be the byte offset into the register I suppose. Seems like a good idea to me. Mark