From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30419 invoked by alias); 18 Aug 2002 15:49:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30412 invoked from network); 18 Aug 2002 15:49:15 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 18 Aug 2002 15:49:15 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17gSIS-0002Vd-00; Sun, 18 Aug 2002 10:48:56 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17gSIx-0005Jb-00; Sun, 18 Aug 2002 11:49:27 -0400 Date: Sun, 18 Aug 2002 08:49:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Jason R Thorpe , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Don't complain about unknown OSABI Message-ID: <20020818154927.GA20358@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Jason R Thorpe , gdb-patches@sources.redhat.com References: <3D5FC00D.50001@ges.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D5FC00D.50001@ges.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-08/txt/msg00499.txt.bz2 On Sun, Aug 18, 2002 at 11:41:01AM -0400, Andrew Cagney wrote: > Hello, > > The attached patch removes the warning message that is printed when the > OSABI is unknown (all the sniffers failed). > > When debugging an embedded executable, there is no OSABI info. Hence I > don't think the warning should be issued. This can be seen when > debugging a GCC created, mips-elf executable. > > thoughts? > Andrew I like it. I asked for this change about two months ago when I noticed it on mips-elf. And there's a typo in the message you're removing, too. [On the related hand, we just had some reports about a case where the OS ABI is isn't detected (on uClibc) - do you think a (configure.tgt based or *.mt based rather than in a header, I think) way to specify the default OS ABI based on the target triplet would be appropriate? Linux kernels do not have ABI tagging, which comes from glibc, but generally use the Linux OS ABI.] > 2002-08-18 Andrew Cagney > > * osabi.c (gdbarch_init_osabi): Don't complain about an unknown > ABI. > > Index: osabi.c > =================================================================== > RCS file: /cvs/src/src/gdb/osabi.c,v > retrieving revision 1.5 > diff -u -r1.5 osabi.c > --- osabi.c 27 Jul 2002 01:28:43 -0000 1.5 > +++ osabi.c 18 Aug 2002 13:53:49 -0000 > @@ -232,13 +232,8 @@ > > if (osabi == GDB_OSABI_UNKNOWN) > { > - /* Don't complain about not knowing the OS ABI if we don't > - have an inferior. */ > - if (info.abfd) > - fprintf_filtered > - (gdb_stderr, "GDB doesn't recognize the OS ABI of the inferior. " > - "Attempting to continue with the default %s settings", > - bfd_printable_arch_mach (arch_info->arch, arch_info->mach)); > + /* Don't complain about not knowing the OS ABI. Assume the user > + knows what they are doing. */ > return; > } > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer