From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23621 invoked by alias); 17 Aug 2002 00:47:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23611 invoked from network); 17 Aug 2002 00:47:44 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250) by sources.redhat.com with SMTP; 17 Aug 2002 00:47:44 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7H0lZ1x001397; Sat, 17 Aug 2002 02:47:35 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7H0lZWM015010; Sat, 17 Aug 2002 02:47:35 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7H0lYmB015007; Sat, 17 Aug 2002 02:47:34 +0200 (CEST) Date: Fri, 16 Aug 2002 17:47:00 -0000 Message-Id: <200208170047.g7H0lYmB015007@elgar.kettenis.dyndns.org> From: Mark Kettenis To: schwab@suse.de CC: tromey@redhat.com, fnasser@redhat.com, ezannoni@redhat.com, gdb-patches@sources.redhat.com In-reply-to: (message from Andreas Schwab on Fri, 16 Aug 2002 21:20:26 +0200) Subject: Re: [RFA/TESTSUITE]: readline tests References: <87y9c1rodk.fsf@fleche.redhat.com> <3D59661F.C4E69AA7@redhat.com> <15705.26605.876458.521420@localhost.redhat.com> <3D596903.90900FB1@redhat.com> <87vg6eque4.fsf@fleche.redhat.com> <86adno6l3q.fsf@elgar.kettenis.dyndns.org> <87it2ay9gw.fsf@fleche.redhat.com> X-SW-Source: 2002-08/txt/msg00478.txt.bz2 From: Andreas Schwab Date: Fri, 16 Aug 2002 21:20:26 +0200 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux) Content-Type: text/plain; charset=iso-8859-1 Tom Tromey writes: |> I think this means that sending C-o didn't cause an operate-and-get-next. |> The subsequent problems are caused by this. Note that C-o is typically also allocated to the tty flush (DISCARD) character. Since readline does not reset the IEXTEN flag the flush character may still be intercepted by the tty driver even in non-canonical input. Yup, that's what's happening. After $ stty discard ^Y operate-and-get-next works fine. So we should either reset the IEXTEN or set DISCARD to _POSIX_VDISABLE, either in readline or GDB. I'm inclined to make the attached patch to readline, since something similar is already done for LNEXT. Should I submit it to the readline maintainer? PS Something strange is still happening. Some operate-and-get-next tests still fail when a .gdb_history file is present in the current directory that has more than 254 lines. If no .gdb_history file is present or if it contains less than 255 lines, the tests succeed. Unfortunately a test that gets run earlier produces just that; a .gdb_history file with 257 lines. Anyway, it seems that I've found a bug in the history code. I'll see if I can find it. Index: rltty.c =================================================================== RCS file: /cvs/src/src/readline/rltty.c,v retrieving revision 1.5 diff -u -p -r1.5 rltty.c --- rltty.c 8 Jan 2001 14:57:30 -0000 1.5 +++ rltty.c 17 Aug 2002 00:25:48 -0000 @@ -598,6 +598,10 @@ prepare_terminal_settings (meta_flag, ot be necessary. */ #if defined (TERMIOS_TTY_DRIVER) && defined (_POSIX_VDISABLE) +#if defined (VDISCARD) + tiop->c_cc[VDISCARD] = _POSIX_VDISABLE; +#endif + #if defined (VLNEXT) tiop->c_cc[VLNEXT] = _POSIX_VDISABLE; #endif