Re: patch for PR gdb/574

david carlton
2002-07-22T19:16:26Z

On Mon, 22 Jul 2002 15:02:20 -0400, Daniel Jacobowitz <drow@mvista.com> said:

> First, do you have an FSF copyright assignment on file?

It's in the mail.

> Second of all, VALUE_ENCLOSING_TYPE is a bad idea, as far as I'm
> concerned.

Thanks for the feedback; I'll poke around some more in the ChangeLog.

> On Mon, Jul 22, 2002 at 11:42:58AM -0700, david carlton wrote:

>> Also (and this may be related to that bad memory access), there
>> seems to be a difference of opinion among various pieces of code as
>> to whose job it is to demangle symbols that you want to look up in
>> symbol tables.

> For the latter, generally one should look up demangled names.
> Especially now that I've hashed the symbol tables based on the
> demangled name!

symtab.c(lookup_symbol) still tries to demangle the symbol name. I
poked around with this a bit last Friday, and I'm pretty sure that
this caused a problem (note that the rtti function was demangling the
name itself, and even demangling it beyond what cplus_demangle does).
I don't have enough of a feel for whose job it is to do what here to
be sure which functions are demangling inappropriately, but I'm pretty
sure that one of them is.