From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24767 invoked by alias); 14 Aug 2002 22:07:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24760 invoked from network); 14 Aug 2002 22:07:01 -0000 Received: from unknown (HELO monkey.daikokuya.co.uk) (213.152.55.49) by sources.redhat.com with SMTP; 14 Aug 2002 22:07:01 -0000 Received: from neil by monkey.daikokuya.co.uk with local (Exim 3.35 #1 (Debian)) id 17f6Hy-0003Hr-00; Wed, 14 Aug 2002 23:06:50 +0100 Date: Wed, 14 Aug 2002 15:07:00 -0000 From: Neil Booth To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [TESTSUITE] assert (char == signed char) Message-ID: <20020814220650.GB12340@daikokuya.co.uk> References: <3D5AC6F4.8D119BF4@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D5AC6F4.8D119BF4@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2002-08/txt/msg00354.txt.bz2 Michael Snyder wrote:- > There seem to be some tests in the testsuite that are > based on the assumption that chars are signed, and that > will fail if they are unsigned. > > Eg: > sizeof.exp: check valueof ((int) (char)) -1 == -1 > (prints 255 if char == unsigned) > > pointers.exp: ptype pC > (outputs "unsigned char *" if char == unsigned) > > Any thoughts? Should these be regularized to accept unsigned? > Should it be based on a configure variable? I'd pass -fsigned-char; that's done in some other tests. Neil.