From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17569-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13870 invoked by alias); 13 Aug 2002 21:39:28 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13854 invoked from network); 13 Aug 2002 21:39:26 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250)
  by sources.redhat.com with SMTP; 13 Aug 2002 21:39:26 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7DLdHSx000424;
	Tue, 13 Aug 2002 23:39:17 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7DLdDL0026624;
	Tue, 13 Aug 2002 23:39:13 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7DLdDnd026621;
	Tue, 13 Aug 2002 23:39:13 +0200 (CEST)
Date: Tue, 13 Aug 2002 14:39:00 -0000
Message-Id: <200208132139.g7DLdDnd026621@elgar.kettenis.dyndns.org>
From: Mark Kettenis <kettenis@chello.nl>
To: ac131313@ges.redhat.com
CC: gdb-patches@sources.redhat.com
In-reply-to: <3D591939.1020706@ges.redhat.com> (message from Andrew Cagney on
	Tue, 13 Aug 2002 10:35:37 -0400)
Subject: Re: [rfa:i386] Add mmx registers
References: <3D55A89F.9040300@ges.redhat.com> <867kiwkky6.fsf@elgar.kettenis.dyndns.org> <3D5805BF.2050409@ges.redhat.com> <3D591939.1020706@ges.redhat.com>
X-SW-Source: 2002-08/txt/msg00319.txt.bz2

   Date: Tue, 13 Aug 2002 10:35:37 -0400
   From: Andrew Cagney <ac131313@ges.redhat.com>

   > Hello,
   > 
   > This adds mmx registers to the i386.
   > 

   Done, this is what I committed.

Ouch!  This patch uncovers a problem in the new regcache code and
segfaults on my FreeBSD 4.6-STABLE system.  The problem is that:

   +  set_gdbarch_pseudo_register_read (gdbarch, i386_pseudo_register_read);
   +  set_gdbarch_pseudo_register_write (gdbarch, i386_pseudo_register_write);

changes the i386 target's register cache from "legacy" to "new".  This
means that there isn't room for the pseudo registers in
register_valid_p, yet registers_changed() tries to frob the entries
for the pseudo registers.

I don't see an obvious way to fix this.  Any bright ideas Andrew?

Mark