From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27167 invoked by alias); 1 Aug 2002 19:21:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27156 invoked from network); 1 Aug 2002 19:21:51 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 1 Aug 2002 19:21:51 -0000 Received: from dsl254-114-118.nyc1.dsl.speakeasy.net ([216.254.114.118] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17aLWB-0001Fy-00; Thu, 01 Aug 2002 14:21:51 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17aLWE-0004rk-00; Thu, 01 Aug 2002 15:21:54 -0400 Date: Thu, 01 Aug 2002 12:21:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH] mips n64 support, part 1 Message-ID: <20020801192154.GA18466@nevyn.them.org> Mail-Followup-To: Kevin Buettner , Andrew Cagney , gdb-patches@sources.redhat.com References: <1020731182328.ZM22007@localhost.localdomain> <3D4985BA.1080308@ges.redhat.com> <20020801190652.GA13050@nevyn.them.org> <1020801191336.ZM28539@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1020801191336.ZM28539@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-08/txt/msg00013.txt.bz2 On Thu, Aug 01, 2002 at 12:13:36PM -0700, Kevin Buettner wrote: > On Aug 1, 3:06pm, Daniel Jacobowitz wrote: > > > On Thu, Aug 01, 2002 at 03:02:18PM -0400, Andrew Cagney wrote: > > > >@@ -4352,7 +4354,11 @@ mips_gdbarch_init (struct gdbarch_info i > > > > break; > > > > case bfd_mach_mips8000: > > > > case bfd_mach_mips10000: > > > >- mips_abi = MIPS_ABI_N32; > > > >+ if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour > > > >+ && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS64) > > > >+ mips_abi = MIPS_ABI_N64; > > > >+ else > > > >+ mips_abi = MIPS_ABI_N32; > > > > break; > > > > } > > > > } > > > > > > This bit should at least have a comment explaining the assumptions > > > behind it -- have you actually seen this code being triggered? I don't > > > think the code is ever reached (unless the executable is very old) as > > > the earlier: > > > > > > /* GCC creates a pseudo-section whose name describes the ABI. */ > > > if (mips_abi == MIPS_ABI_UNKNOWN && info.abfd != NULL) > > > bfd_map_over_sections (info.abfd, mips_find_abi_section, &mips_abi); > > > > > > should catch most modern cases. > > > > Kevin is using IRIX CC, I believe. > > Yes. > > > The marker sections are GCC-specific. > > Actually, I think they're platform specific. In the tests I did yesterday, > I didn't see the marker sections in binaries created by gcc either. > > I'll add a comment though. Blah. They appear to be conditioned on TARGET_GAS, for whatever reason; Eric added that in Sept. 2001, not long after they were originally added. Hmm... (mips_asm_file_start): Add new section to pass abi to gdb. Just curious - did Red Hat's internal tree have code in GDB to read this, before I added it to the community tree? There was about nine months worth of lag there. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer