Re: RFA: Make cli-out follow gdb_stdout

Pierre Muller
2002-08-19T14:50:11Z

At 20:30 17/07/2002 , Daniel Jacobowitz a Ã©crit:
>Right now, when you create a cli_out object via cli_out_new, you pass the
>value of gdb_stdout. If we want to temporarily redirect output, that loses.
>Rather than temporarily changing the UI, I'd like to have cli_out_new follow
>gdb_stdout.
>
>There were two ways to do this:
> - hardcode the relationship between cli_out and gdb_stdout, since all
>callers pass the same thing.
> - Pass &gdb_stdout instead of gdb_stdout.
>
>I opted for the latter, as Pierre originally suggested. If someone's got a
>preference for the former I can switch easily enough. I need this patch
>before I can submit the code to support '>' and '>>', based on Tom Tromey's
>patch from last October.
>
>OK?

This mail is followed by several others in which Andrew and Daniel argue about
the proposed patch...

Andrew says
>>So the assertion:
>>
>> global uiout->stream->ui_file == global gdb_stdout
>>
>>doesn't hold :-(

But I think there is a confusion at that point
(at least after reading of the thread, I was not really sure that
it was clear).
My impression is that the current way the cli_out_new works is not correct
because if you change gdb_stdout, this change is not reflected in
the uiout global var. Thus the above assertion
does not hold in the current old code, but if I understood Daneil's patch correctly
that patch should have solved that issue.

Thus I am very disappointed by the final outcome of this thread...
I really tought that Daniel's idea was the way to go,
as uiout is not known in all source files, but gdb_stdout is.

Also, I didn't understand the intent of Andrew concerning this issue.
Andrew, could you try to reformulate your point of view?

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99