From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16983-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 22380 invoked by alias); 18 Jul 2002 12:54:34 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 22368 invoked from network); 18 Jul 2002 12:54:32 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 18 Jul 2002 12:54:32 -0000
Received: by fw-cam.cambridge.arm.com; id NAA24525; Thu, 18 Jul 2002 13:54:31 +0100 (BST)
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma024465; Thu, 18 Jul 02 13:54:26 +0100
Received: from cam-mail2.cambridge.arm.com (cam-mail2 [172.16.1.91])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id NAA22276;
	Thu, 18 Jul 2002 13:54:26 +0100 (BST)
Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18])
	by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id NAA00660;
	Thu, 18 Jul 2002 13:54:25 +0100 (BST)
Message-Id: <200207181254.NAA00660@cam-mail2.cambridge.arm.com>
To: Jim Blandy <jimb@redhat.com>
cc: Richard.Earnshaw@arm.com, binutils@sources.redhat.com, irickards@arm.com,
        gdb-patches@sources.redhat.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
X-Url: http://www.arm.com/
Subject: Re: PATCH/RFC handle missing DW_AT_comp_dir attribute 
In-reply-to: Your message of "17 Jul 2002 17:25:10 CDT."
             <npd6tmj8l5.fsf@zwingli.cygnus.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 18 Jul 2002 08:00:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-07/txt/msg00386.txt.bz2

> 
> Richard Earnshaw <rearnsha@arm.com> writes:
> > This problem was found by a colleague while using GDB with the ADS tools.
> > 
> > These tools do not set the DW_AT_comp_dir attribute in a compilation unit 
> > entry, so GDB will crash trying to reference a NULL pointer.

> 
> Sorry --- how does this patch fix a GDB crash?  GDB doesn't use BFD to
> read debugging information.

Ah, sorry, it was my understanding from Ian that it was in GDB.  
Apparently the problem was seen in addr2line, and rather than a crash we 
just got an empty filename (since the first argument passed to concat was 
a NULL pointer).

R.