From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23718 invoked by alias); 11 Jul 2002 15:07:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23711 invoked from network); 11 Jul 2002 15:07:52 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 11 Jul 2002 15:07:52 -0000 Received: from dsl254-114-096.nyc1.dsl.speakeasy.net ([216.254.114.96] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17SfXq-0005Ff-00; Thu, 11 Jul 2002 10:07:50 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17SfXs-0002ZP-00; Thu, 11 Jul 2002 11:07:52 -0400 Date: Thu, 11 Jul 2002 09:22:00 -0000 From: Daniel Jacobowitz To: Petr Sorfa Cc: "gdb-patches@sources.redhat.com" Subject: Re: [PATCH] DW_AT_calling_convention support REV 2 Message-ID: <20020711150752.GA9585@nevyn.them.org> Mail-Followup-To: Petr Sorfa , "gdb-patches@sources.redhat.com" References: <3D2C80A8.35D678FE@caldera.com> <20020710184710.GA923@nevyn.them.org> <3D2C8D8C.E5127E28@caldera.com> <20020710193458.GA28939@nevyn.them.org> <3D2D9FB1.87EABC20@caldera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D2D9FB1.87EABC20@caldera.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-07/txt/msg00227.txt.bz2 On Thu, Jul 11, 2002 at 11:09:37AM -0400, Petr Sorfa wrote: > Hi Daniel, > > > main_name(), I assume. Basically I would like everywhere that > > currently checks by a strcmp/STREQ with main_name() to use > > is_main_symbol () instead, etc. Things that call lookup_symbol on > > main_name() should just use get_main_symbol () if possible. Then > > set_main_name () could include calling lookup_symbol(main_name()), so > > that get_main_symbol would always be valid, etc.... > Unforuntately after looking at this I realized this will not work always > correctly. It is quite possible that a symbol is not created for "main" > until much later. There are calls to set_main_name() before the symbol > is created, so your proposition to do a lookup_symbol() in > set_main_name() will not work in all cases. > > I suggest that the get_main_symbol() is altered to your suggestions, to > which I want to add further checks such as ensuring that the main name > is equal to the main symbol's name. > > If this is ok with you, I'll do a rev 3 patch for this and submit it. That's unfortunate, but I guess not surprising... yes, your solution sounds good to me. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer