From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16772-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30598 invoked by alias); 10 Jul 2002 09:25:21 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30569 invoked from network); 10 Jul 2002 09:25:18 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 10 Jul 2002 09:25:18 -0000
Received: by fw-cam.cambridge.arm.com; id KAA16956; Wed, 10 Jul 2002 10:25:17 +0100 (BST)
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma016451; Wed, 10 Jul 02 10:24:41 +0100
Received: from cam-mail2.cambridge.arm.com (cam-mail2 [172.16.1.91])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id KAA22356;
	Wed, 10 Jul 2002 10:24:41 +0100 (BST)
Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18])
	by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id KAA09464;
	Wed, 10 Jul 2002 10:24:40 +0100 (BST)
Message-Id: <200207100924.KAA09464@cam-mail2.cambridge.arm.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com,
        Richard.Earnshaw@arm.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
X-Url: http://www.arm.com/
Subject: Re: [PATCH] Remove bogosities from dwarf2cfi.c:cfi_pop_frame() 
In-reply-to: Your message of "Mon, 08 Jul 2002 14:36:35 EDT."
             <3D29DBB3.1080904@ges.redhat.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 10 Jul 2002 05:22:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-07/txt/msg00175.txt.bz2

> > Using alloca() here is pretty obvious.  I discussed the other fix with
> > Michael Ludvig.
> > 
> > Checked in.
> > 
> > Mark
> > 
> > Index: ChangeLog
> > from  Mark Kettenis  <kettenis@gnu.org>
> > 
> > 	* dwarf2cfi.c (cfi_pop_frame): Use alloca() for regbuf.
> > 	Don't call get_current_frame().
> > 
> 
> Heads up,
> 
> I think the write_register_bytes() call should be replaced by 
> regcache_register_write(current_regcache, ).  This is new code so it 
> doesn't need to go through any of that nasty write_register_bytes() stuff.
> 
> Andrew
> 
> 

Why is this code trying to poke directly into the regcache at all?  AFAICT 
it should be operating on the pseudo registers not the cache.

R.