From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17202 invoked by alias); 3 Jul 2002 15:02:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17167 invoked from network); 3 Jul 2002 15:02:07 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 3 Jul 2002 15:02:07 -0000 Received: from [216.254.114.110] (helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17Pldg-0007HQ-00; Wed, 03 Jul 2002 10:01:52 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17Pldj-0002P4-00; Wed, 03 Jul 2002 11:01:55 -0400 Date: Wed, 03 Jul 2002 08:05:00 -0000 From: Daniel Jacobowitz To: Michal Ludvig Cc: GDB Patches Subject: Re: [patch] gdbserver for x86-64 Message-ID: <20020703150155.GA9114@nevyn.them.org> Mail-Followup-To: Michal Ludvig , GDB Patches References: <3D230CFA.5060602@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D230CFA.5060602@suse.cz> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-07/txt/msg00056.txt.bz2 On Wed, Jul 03, 2002 at 04:40:58PM +0200, Michal Ludvig wrote: > Hi all, > Pretty obvious one. If noone complains, I'll commit it tomorrow. > > Michal Ludvig > -- > * SuSE CR, s.r.o * mludvig@suse.cz > * +420 2 9654 5373 * http://www.suse.cz > 2002-07-03 Michal Ludvig > > * gdbserver/linux-x86-64-low.c (x86_64_fill_gregset): Change type in > explicit cast to CORE_ADDR so that pointer arithmetic works. > (x86_64_store_gregset): Ditto + parameter made const. > (x86_64_store_fpregset): Parameter made const. Could you change the reg_map instead, please? It's used outside of this file and expected to be in byte offsets. Just add *4 or *8 where appropriate as I did in the i386 file. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer