From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32541 invoked by alias); 30 Jun 2002 19:33:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32533 invoked from network); 30 Jun 2002 19:33:49 -0000 Received: from unknown (HELO dragon.nuxi.com) (66.92.13.169) by sources.redhat.com with SMTP; 30 Jun 2002 19:33:49 -0000 Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.4/8.12.2) with ESMTP id g5UJXltL071596; Sun, 30 Jun 2002 12:33:47 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.5/8.12.4/Submit) id g5UJXkNe071595; Sun, 30 Jun 2002 12:33:46 -0700 (PDT) Date: Sun, 30 Jun 2002 12:33:00 -0000 From: "David O'Brien" To: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: Include param.h on FreeBSD/i386 Message-ID: <20020630123346.B71518@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020628131544.A53773@dragon.nuxi.com> <86k7og24w7.fsf@elgar.kettenis.dyndns.org> <20020630120003.B70260@dragon.nuxi.com> <20020630190436.GA4210@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020630190436.GA4210@nevyn.them.org>; from drow@mvista.com on Sun, Jun 30, 2002 at 03:04:36PM -0400 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 X-SW-Source: 2002-06/txt/msg00589.txt.bz2 On Sun, Jun 30, 2002 at 03:04:36PM -0400, Daniel Jacobowitz wrote: > > > > 2002-06-28 David O'Brien > > > > > > > > * config/i386/nm-fbsd.h: Include . > > > > * config/i386/tm-fbsd.h: Likewise. > > > > > > Hi David. Can you tell me why this is needed? > > > > Some code I added to GDB 5.2 in the FreeBSD source tree needs it. That > > code isn't ready to submit back yet. Since the include is benign but I > > wanted to reduce the diffs where easy. ..snip.. > Including system headers from the tm file is always pretty dodgy - what > do you need it for? How does that include affect cross-debuggers? I needed the __FreeBSD_version symbol and a few of the headers param.h includes. For building a cross-debugger (cross-arch, not cross-OS) w/in the FreeBSD source tree this is still needed (and works). As I mentioned the commit was to reduce changes I have to make in he FreeBSD tree. I didn't think a benign include in a FreeBSD-specific header would raise an eyebrow. :-)