From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7983 invoked by alias); 28 Jun 2002 21:39:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7976 invoked from network); 28 Jun 2002 21:39:09 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 28 Jun 2002 21:39:09 -0000 Received: from 01-062.118.popsite.net ([66.19.120.62] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17O3SJ-0005mo-00; Fri, 28 Jun 2002 16:39:04 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17O3SK-0003wa-00; Fri, 28 Jun 2002 17:39:04 -0400 Date: Fri, 28 Jun 2002 14:39:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: obrien@FreeBSD.org, gdb-patches@sources.redhat.com Subject: Re: [5.2.1] quiet warnings for gdbreplay.c Message-ID: <20020628213904.GA15095@nevyn.them.org> Mail-Followup-To: Andrew Cagney , obrien@FreeBSD.org, gdb-patches@sources.redhat.com References: <20020627204720.A13445@dragon.nuxi.com> <3D1C8AEF.5020508@ges.redhat.com> <20020628180820.GA9115@nevyn.them.org> <3D1CD337.2010205@ges.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D1CD337.2010205@ges.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-06/txt/msg00575.txt.bz2 On Fri, Jun 28, 2002 at 05:20:55PM -0400, Andrew Cagney wrote: > >On Fri, Jun 28, 2002 at 12:12:31PM -0400, Andrew Cagney wrote: > > > >>>+#ifdef HAVE_STRING_H > >>>+#include > >>>+#endif > > > >> > >>Should that bit be "gdb_string.h"? > > > > > >That depends :) gdbreplay is not part of GDB and has a different > >config.h header (tests for a different set of macros). > > (We could always fix that - eliminate that configure file :-^ ) I dunno, I appreciate being able to run configure in the gdbserver/ directory. It means you don't need to a terminal library for your target if you just want gdbserver. A lot of people have seemed to appreciate this. > More seriously, I think someone hacking on gdbreplay is likely to also > be hacking on GDB. Consequently, they are going to expect the two > directories to follow the same coding conventions. We discussed this. The two directories share no code except for signals/signals.c off in its own space. If they share headers, some care is called for. They are not part of the same program! > I had > >eliminated all references to the gdb source code but then I introduced > >an include of "gdb_proc_service.h", since the alternative was just > >duplicating it; I have the feeling we should move that and headers like > >gdb_string.h somewhere common - are they include/gdb/ candidates? > > You mean #include "gdb/gdb_string.h"? I think include/gdb/ is for > external interfaces that are at some level controlled by GDB. Then do we want a separate gdb/gdbint/ directory for this? I strongly prefer that headers shared between GDB and other directories be clearly marked and separated. That'd give me a place to move gdb_proc_service.h, too. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer