From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: obrien@FreeBSD.org, gdb-patches@sources.redhat.com
Subject: Re: [5.2.1] quiet warnings for gdbreplay.c
Date: Fri, 28 Jun 2002 11:08:00 -0000 [thread overview]
Message-ID: <20020628180820.GA9115@nevyn.them.org> (raw)
In-Reply-To: <3D1C8AEF.5020508@ges.redhat.com>
On Fri, Jun 28, 2002 at 12:12:31PM -0400, Andrew Cagney wrote:
> >+#ifdef HAVE_STRING_H
> >+#include <string.h>
> >+#endif
>
> Should that bit be "gdb_string.h"?
That depends :) gdbreplay is not part of GDB and has a different
config.h header (tests for a different set of macros). I had
eliminated all references to the gdb source code but then I introduced
an include of "gdb_proc_service.h", since the alternative was just
duplicating it; I have the feeling we should move that and headers like
gdb_string.h somewhere common - are they include/gdb/ candidates?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-06-28 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-27 20:47 David O'Brien
2002-06-28 9:12 ` Andrew Cagney
2002-06-28 11:08 ` Daniel Jacobowitz [this message]
2002-06-28 11:38 ` David O'Brien
2002-06-28 14:20 ` Andrew Cagney
2002-06-28 14:39 ` Daniel Jacobowitz
2002-07-09 14:15 ` Andrew Cagney
2003-06-21 17:40 ` Daniel Jacobowitz
2003-06-21 17:54 ` Andrew Cagney
2003-06-21 18:07 ` Daniel Jacobowitz
2003-06-22 3:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020628180820.GA9115@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=obrien@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox