From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 400 invoked by alias); 27 Jun 2002 17:18:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 390 invoked from network); 27 Jun 2002 17:18:17 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 27 Jun 2002 17:18:17 -0000 Received: from 02-068.118.popsite.net ([66.19.120.68] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17Ncu9-00049u-00; Thu, 27 Jun 2002 12:18:02 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17Ncu9-0000AZ-00; Thu, 27 Jun 2002 13:18:01 -0400 Date: Thu, 27 Jun 2002 10:18:00 -0000 From: Daniel Jacobowitz To: Andrew Volkov Cc: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com Subject: Re: [RFA/RFC] blockframe.c Fix errorneous addr check Message-ID: <20020627171800.GA631@nevyn.them.org> Mail-Followup-To: Andrew Volkov , gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com References: <2E74F312D6980D459F3A05492BA40F8DFE339D@clue.transas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2E74F312D6980D459F3A05492BA40F8DFE339D@clue.transas.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-06/txt/msg00556.txt.bz2 On Thu, Jun 27, 2002 at 09:13:41PM +0400, Andrew Volkov wrote: > Hi, > > This patch fix wrong detection of belonging addr to startup file: > if call main is last instuction in crt0, then > inside_entry_file erroneously return false. > > Ok to commit? > Andrey > > P.S. Possible this bug not in this func, but in symbol reader. I'm inclined to believe the bug is in the symbol reader. Upper PC bounds are generally exclusive - first address after the function. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer