From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4635 invoked by alias); 26 Jun 2002 15:16:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4376 invoked from network); 26 Jun 2002 15:16:04 -0000 Received: from unknown (HELO tomago.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 26 Jun 2002 15:16:04 -0000 Received: (from graces@localhost) by tomago.toronto.redhat.com (8.11.6/8.11.6) id g5QFG2M05315; Wed, 26 Jun 2002 11:16:02 -0400 Date: Wed, 26 Jun 2002 08:16:00 -0000 From: Grace Sainsbury To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] monitor_ops regnames array Message-ID: <20020626111602.A5096@tomago.toronto.redhat.com> References: <20020625170708.A4105@tomago.toronto.redhat.com> <3D1930B2.9040708@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3D1930B2.9040708@cygnus.com>; from ac131313@cygnus.com on Tue, Jun 25, 2002 at 11:10:42PM -0400 X-SW-Source: 2002-06/txt/msg00536.txt.bz2 On Tue, Jun 25, 2002 at 11:10:42PM -0400, Andrew Cagney wrote: > > With multi-arch NUM_REGS is not a constant, but monitor.c was treating > > as a constant in determining the size of the numregs array. So I added > > a function to monitor_ops that returns the register names, and doesn't > > need NUM_REGS to be constant. > > Outch. > > > I only changed the rom files that are compiled for the m68k, but the > > array is still there. > > Ok, I think having a functional interface will be better any way. > > > ok to commit? > > Yes, after the below tweaks: > I made the changes and committed. grace