Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Switch to generic_func_frame_chain_valid()
Date: Mon, 03 Jun 2002 11:13:00 -0000	[thread overview]
Message-ID: <20020603181255.GA28813@branoic.them.org> (raw)
In-Reply-To: <3CFBAC77.5B3AADD3@redhat.com>

On Mon, Jun 03, 2002 at 10:50:47AM -0700, Michael Snyder wrote:
> Andrew Cagney wrote:
> > 
> > > On Sat, Jun 01, 2002 at 06:20:22PM -0400, Andrew Cagney wrote:
> > >
> > >> Hello,
> > >>
> > >> This finishes off (I think) the FRAME_CHAIN_VALID debate.  It sets it to
> > >> generic_func_frame_chain_valid().  That function being tweaked to handle
> > >> both generic dummy frame and the old style frame cases.
> > >>
> > >> I'll commit it in a few days.
> > >>
> > >> Andrew
> > >
> > >
> > > After this goes in, can we start switching existing targets?  That
> > > seemed to be the real point of debate - file_frame_chain_valid versus
> > > func_frame_chain_valid.  With the addition of a 'set' variable for
> > > people who prefer the file_frame_chain_valid behavior, I don't see any
> > > reason not to.
> > 
> > For natives (hmm, need a new name - UNIX like targets?) I think
> > definitly and asap.  For more embedded targets, yes, with set - do any
> > targets have custom frame-chain functions?
> 
> Yes, many.  Did you mean "custom frame-chain-valid functions"?
> Yes, I believe there are some of those too.

Assuming Andrew meant custom f-c-valid functions, then there are
several; all of them just add additional restrictions on the PC instead
of taking away.  So I will update them to call the generic function
after they perform their additional checks, instead of duplicating. 
Sound good?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-06-03 18:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-01 15:20 Andrew Cagney
2002-06-02 10:18 ` Daniel Jacobowitz
2002-06-03  6:29   ` Andrew Cagney
2002-06-03 11:05     ` Michael Snyder
2002-06-03 11:13       ` Daniel Jacobowitz [this message]
2002-06-03 11:49         ` Andrew Cagney
2002-06-03 12:11           ` Daniel Jacobowitz
2002-06-08 11:35 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020603181255.GA28813@branoic.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox