From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11063 invoked by alias); 28 May 2002 16:03:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11015 invoked from network); 28 May 2002 16:03:35 -0000 Received: from unknown (HELO branoic) (12.234.96.134) by sources.redhat.com with SMTP; 28 May 2002 16:03:35 -0000 Received: from drow by branoic with local (Exim 3.35 #1 (Debian)) id 17CjR7-0003Dg-00; Tue, 28 May 2002 12:03:01 -0400 Date: Tue, 28 May 2002 09:03:00 -0000 From: Daniel Jacobowitz To: "G. Helffrich" Cc: gdb-patches@sources.redhat.com Subject: Re: Proposed gdb patch Message-ID: <20020528160300.GB12301@branoic.them.org> Mail-Followup-To: "G. Helffrich" , gdb-patches@sources.redhat.com References: <200205281057.LAA00860@xterm1.gly.bris.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200205281057.LAA00860@xterm1.gly.bris.ac.uk> User-Agent: Mutt/1.3.28i X-SW-Source: 2002-05/txt/msg00971.txt.bz2 On Tue, May 28, 2002 at 11:57:14AM +0100, G. Helffrich wrote: > > Dear GDBers - > > Here is a patch to gdb 5.1.1 that adds functionality to the gdb command > language. It implements the "edit" command featured in Sun's dbx, which > invokes your favorite file editor on the active line of the program being > debugged. ChangeLog entry and patches follow. > > George > > ---------- > > 2002-04-26 George Helffrich > > * cli/cli-cmds.c, defs.h, source.c, gdb.1: Add edit command. This > command mimics the behavior of Sun dbx, and invokes an editor at > the current line number. Editor comes from EDITOR environment > variable, or defaults to /bin/ex. My bias is showing, but could you default to: - vi rather than ex, since fullscreen edit support is far more prevalent than not in this decade. - Using $PATH, since I believe that neither BSDs nor Linuxen put editors in /bin generally. Oh, and again, you may want to update gdb.texinfo. That's the current updated documentation. Thanks for the patch! -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer