From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10532 invoked by alias); 13 May 2002 19:57:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10522 invoked from network); 13 May 2002 19:57:12 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 13 May 2002 19:57:12 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 177LwP-0001AV-00; Mon, 13 May 2002 15:57:05 -0400 Date: Mon, 13 May 2002 12:57:00 -0000 From: Daniel Jacobowitz To: Daniel Berlin Cc: i Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [RFA] Type cleanups Message-ID: <20020513195705.GA4473@nevyn.them.org> Mail-Followup-To: Daniel Berlin , i Andrew Cagney , gdb-patches@sources.redhat.com References: <20020513184651.GA16618@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2002-05/txt/msg00490.txt.bz2 On Mon, May 13, 2002 at 03:54:29PM -0400, Daniel Berlin wrote: > > > cache, and no one has noticed me adding another assertion to every > > > gdbarch accessor function, I don't expect changing the above to opaque > > > to be a significant problem :-) > > > > I think you may be underestimating the frequency of some of the TYPE > > accessors... but if I get a chance, I'll benchmark it. > If worst comes to worst, you can always make them static inlines in the > header. > That way, you can still debug them easily, but if optimization is on, .... > --Dan The problem is, then the type isn't opaque. Or if it is, it's opaque via some casting, which makes debugging more annoying. (Though I should really just write some good gdb macros and utility functions for debugging types; with the other type patch I posted, printing the type becomes somewhat less useful.) -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer