Re: [patch/rfc] Tweak MAINTAINERS to use SED/TR

[Daniel Jacobowitz <drow@mvista.com>]

On Mon, May 13, 2002 at 03:08:58PM -0400, Andrew Cagney wrote:
> Hello,
> 
> The attached hopefully addresses the problems Daniel encountered when 
> trying to build all targets.
> 
> I'll table it for a few days then, baring comments, commit.
> 
> enjoy,
> Andrew

> 2002-05-13  Andrew Cagney  <ac131313@redhat.com>
> 
> 	* MAINTAINERS (--enable-gdb-build-warnings): Rewrite script to use
> 	`tr' and `sed'.  Mention that `broken' targets are not expected to
> 	build.
> 
> Index: MAINTAINERS
> ===================================================================
> RCS file: /cvs/src/src/gdb/MAINTAINERS,v
> retrieving revision 1.172
> diff -u -r1.172 MAINTAINERS
> --- MAINTAINERS	11 May 2002 14:18:14 -0000	1.172
> +++ MAINTAINERS	13 May 2002 18:38:50 -0000
> @@ -192,21 +192,33 @@
>  the obvious fix rule) to ``maintenance only'' targets.  The change
>  shall be sanity checked by compiling with one of the listed targets.
>  
> -The GAWK segment:
> +The bourn shell script:

Bourne, I think.

> -  awk < "${maintainers}" '
> -  $2 ~ /--target=.*/ {
> -    targets = gensub (/^.*--target=/, "", 1, $2)
> -    warnings = gensub (/[)]*$/, "", 1, $3)
> -    split (targets, targ, /,/)
> -    for (i in targ) {
> -	print targ[i], warnings
> -    }
> -  }'
> +cat MAINTAINERS | tr -s '[\t]' '[ ]' | sed -n '
> +/^[ ]*[-a-z0-9\.]*[ ]*[(]*--target=.*/ !d
> +s/^.*--target=//
> +s/).*$//
> +h
> +:loop
> +  g
> +  /^[^ ]*,/ !b end
> +  s/,[^ ]*//
> +  p
> +  g
> +  s/^[^,]*,//
> +  h
> +b loop
> +:end
> +p
> +'

Doesn't work for hppa1.1-hp-proelf; outputs

hppa1.1-hp-proelf broken

>  
> -can be used to generate a full list of --target=
> ---enable-gdb-build-warnings= pairs.
> +can be used to generate a complete list of --target=
> +--enable-gdb-build-warnings= pairs of the form:
>  
> +	arc-elf ,-Werror
> +	hppa1.1-hp-proelf broken
> +
> +The ``broken'' targets, while listed, are not expected to build.

What's arc-elf doing here?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer