From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31941 invoked by alias); 13 May 2002 15:23:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31922 invoked from network); 13 May 2002 15:23:25 -0000 Received: from unknown (HELO dr-evil.shagadelic.org) (208.176.2.162) by sources.redhat.com with SMTP; 13 May 2002 15:23:25 -0000 Received: by dr-evil.shagadelic.org (Postfix, from userid 7518) id 899889869; Mon, 13 May 2002 08:23:24 -0700 (PDT) Date: Mon, 13 May 2002 08:23:00 -0000 From: Jason R Thorpe To: Nick Clifton Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Include sh64 support for shle-*-netbsdelf* Message-ID: <20020513082324.R3435@dr-evil.shagadelic.org> Reply-To: thorpej@wasabisystems.com Mail-Followup-To: Jason R Thorpe , Nick Clifton , binutils@sources.redhat.com, gdb-patches@sources.redhat.com References: <20020511115603.W3435@dr-evil.shagadelic.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from nickc@cambridge.redhat.com on Mon, May 13, 2002 at 09:48:26AM +0100 Organization: Wasabi Systems, Inc. X-SW-Source: 2002-05/txt/msg00457.txt.bz2 On Mon, May 13, 2002 at 09:48:26AM +0100, Nick Clifton wrote: > > + shle-*-netbsdelf*) > > + targ_defvec=bfd_elf32_shlnbsd_vec > > + targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec" > > +#ifdef BFD64 > > + targ_selvecs="${targ_selvecs} bfd_elf32_sh64_vec bfd_elf32_sh64l_vec bfd_elf64_sh64_vec bfd_elf64_sh64l_vec" > > +#endif > > + ;; > > sh*le-*-netbsdelf*) > > targ_defvec=bfd_elf32_shlnbsd_vec > > targ_selvecs="bfd_elf32_shnbsd_vec shcoff_vec shlcoff_vec" > > Doesn't the "sh*le-*-netbsdelf*" target (immediately below the lines > you have added) already cover this situation ? It appears as if the intent in other configurations was to include sh64 support only if the target was "sh", not "sh3" or "sh4", etc. Look down one and two more, and you see the sh-*-netbsdelf* (added by hp when the sh64 code went in) and the sh*-*-netbsdelf* (added by me when I checked in NetBSD SH support) configs. -- -- Jason R. Thorpe