From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15039 invoked by alias); 13 May 2002 03:40:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15029 invoked from network); 13 May 2002 03:40:27 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 13 May 2002 03:40:27 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 1776hE-0002vc-00; Sun, 12 May 2002 23:40:24 -0400 Date: Sun, 12 May 2002 20:40:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Type cleanups Message-ID: <20020513034024.GA27096@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20020513003359.GA11672@nevyn.them.org> <3CDF3081.1020900@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CDF3081.1020900@cygnus.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-05/txt/msg00441.txt.bz2 On Sun, May 12, 2002 at 11:18:25PM -0400, Andrew Cagney wrote: > >In order to fix gdb/277, I needed to move a lot of members of 'struct > >type'. This patch flushes out all (that I could find) direct accesses of > >these > >members instead of through the proper macros. It's possible that I missed > >some; if so, the next patch will cause whichever files I missed to stop > >compiling. I'm pretty sure I got them all, though. I also clean up the > >only remaining references to 'sizeof (struct type)': dstread.c had a clone > >of alloc_type, and hpread.c needed to call replace_type like the other > >readers. > > > >This patch should have no effect. On i386-linux, I get byte-for-byte > >identical GDB binaries (all 5591185 bytes of it, debugging information > >and all; no -g3 here). > > > >OK to commit? > > Did you check all the cross targets build per MAINTAINERS? From memory > sh-hms[bfd] and avr[need to look] don't build at present (well as of > ~2002-05-12-gmt). > > If that has been checked, then yes ``obviously''. I'll do that. Sigh, takes forever... least there are scripts for it. BTW, the fragment of awk in MAINTAINERS only works with GNU awk. > Does this mean that ``struct type *'' is becoming opaque? Looking at > the next patch, no, sigh. No. It's accessed so frequently that switching from macros to accessor functions would be a ridiculous performance hit, I think. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer