Re: [RFA] Fix gdb/277 by separating types

Daniel Jacobowitz
2002-05-13T13:41:39Z

On Mon, May 13, 2002 at 08:20:32AM +0300, Eli Zaretskii wrote:
>
> On Sun, 12 May 2002, Daniel Jacobowitz wrote:
>
> > This patch requires my previous cleanup patch. It fixes a test in
> > gdb.c++/method.exp for GCC 3.x/stabs+, and closes gdb/277.
>
> A minor comment about style:
>
> > type = (struct type *) xmalloc (sizeof (struct type));
> > + memset ((char *) (type), 0, sizeof (struct type));
>
> Why the cast to `char *' in the first argument of memset? I thought,
> since we require an ISO C compiler, we shouldn't need those anymore.
> (There are more casts like that in the patch.)
>
> The same goes for casting the return value of xmalloc, I think.

Thanks for catching these. The reason is simple: they were all copies
of a pre-existing memset in alloc_type, and I didn't stop to think
about them :)

--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer