From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6165 invoked by alias); 11 May 2002 11:45:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6150 invoked from network); 11 May 2002 11:45:55 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.114.42) by sources.redhat.com with SMTP; 11 May 2002 11:45:55 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.11.6/8.11.6) with ESMTP id g4BBl7k03807; Sat, 11 May 2002 13:47:07 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.11.6/8.11.6) id g4BBjt711447; Sat, 11 May 2002 13:45:55 +0200 (CEST) (envelope-from kettenis) Date: Sat, 11 May 2002 04:45:00 -0000 From: Mark Kettenis Message-Id: <200205111145.g4BBjt711447@elgar.kettenis.dyndns.org> To: thorpej@wasabisystems.com CC: gdb-patches@sources.redhat.com, obrien@freebsd.org In-reply-to: <20020510100446.E3435@dr-evil.shagadelic.org> (message from Jason R Thorpe on Fri, 10 May 2002 10:04:47 -0700) Subject: Re: [PATCH] Move Alpha BSD register supply/fill to alphabsd-tdep.c References: <20020510100446.E3435@dr-evil.shagadelic.org> X-SW-Source: 2002-05/txt/msg00388.txt.bz2 It looks mostly OK to me. There is a code formatting problem though: the extra spaces between "void" and the function name in the prototypes in alpabsd-tdep.h. Oh, and can you please rename alpha_bsd_* to alphabsd_*, for consistency? Hmm, looking at the names you chose for the alpha_bsd_{fill,supply}_* functions I'm wondering if we should unify the way these kind of functions are defined for the targets that GDB supports. I think the function signatures that you chose are right, i.e. the first argument a char * to some data representing the values of a bunch of registers, and the second argument a register number where -1 means "all registers". Come to think of it, I should probably change the i387_supply_* functions to have that same signature. About the naming of the functions: I think the last part of the name should indicate what exactly the first char * points to. I chose 'fsave' and 'fxsave' for the i387_{fill,supply}_* functions. Therefore I would have chosen 'reg' and 'fpreg' for the alphabsd_{fill,supply}_* functions, since the first argument is supposed to be a 'struct reg' or 'struct fpreg'. Mark