Re: [PATCH] Move Alpha BSD register supply/fill to alphabsd-tdep.c

Mark Kettenis
2002-05-11T11:45:59Z

It looks mostly OK to me. There is a code formatting problem though:
the extra spaces between "void" and the function name in the
prototypes in alpabsd-tdep.h. Oh, and can you please rename
alpha_bsd_* to alphabsd_*, for consistency?

Hmm, looking at the names you chose for the alpha_bsd_{fill,supply}_*
functions I'm wondering if we should unify the way these kind of
functions are defined for the targets that GDB supports. I think the
function signatures that you chose are right, i.e. the first argument
a char * to some data representing the values of a bunch of registers,
and the second argument a register number where -1 means "all
registers". Come to think of it, I should probably change the
i387_supply_* functions to have that same signature. About the naming
of the functions: I think the last part of the name should indicate
what exactly the first char * points to. I chose 'fsave' and 'fxsave'
for the i387_{fill,supply}_* functions. Therefore I would have chosen
'reg' and 'fpreg' for the alphabsd_{fill,supply}_* functions, since
the first argument is supposed to be a 'struct reg' or 'struct fpreg'.

Mark