From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24747 invoked by alias); 11 May 2002 16:16:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24682 invoked from network); 11 May 2002 16:16:13 -0000 Received: from unknown (HELO dr-evil.shagadelic.org) (208.176.2.162) by sources.redhat.com with SMTP; 11 May 2002 16:16:13 -0000 Received: by dr-evil.shagadelic.org (Postfix, from userid 7518) id 778AA9869; Sat, 11 May 2002 09:16:12 -0700 (PDT) Date: Sat, 11 May 2002 09:16:00 -0000 From: Jason R Thorpe To: Mark Kettenis Cc: gdb-patches@sources.redhat.com, obrien@freebsd.org Subject: Re: [PATCH] Move Alpha BSD register supply/fill to alphabsd-tdep.c Message-ID: <20020511091612.Q3435@dr-evil.shagadelic.org> Reply-To: thorpej@wasabisystems.com Mail-Followup-To: Jason R Thorpe , Mark Kettenis , gdb-patches@sources.redhat.com, obrien@freebsd.org References: <20020510100446.E3435@dr-evil.shagadelic.org> <200205111145.g4BBjt711447@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200205111145.g4BBjt711447@elgar.kettenis.dyndns.org>; from kettenis@chello.nl on Sat, May 11, 2002 at 01:45:55PM +0200 Organization: Wasabi Systems, Inc. X-SW-Source: 2002-05/txt/msg00390.txt.bz2 On Sat, May 11, 2002 at 01:45:55PM +0200, Mark Kettenis wrote: > It looks mostly OK to me. There is a code formatting problem though: > the extra spaces between "void" and the function name in the > prototypes in alpabsd-tdep.h. Oh, and can you please rename > alpha_bsd_* to alphabsd_*, for consistency? Ok, made the various tweaks you suggested. Will commit shortly. -- -- Jason R. Thorpe