Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: remember dwarf_line_size
Date: Thu, 09 May 2002 16:31:00 -0000	[thread overview]
Message-ID: <20020509233145.E23A45EA11@zwingli.cygnus.com> (raw)


The change I committed May 6 to dwarf2read.c introduced the new
function dwarf_decode_line_header.  That contained a bunch of
consistency checks which assumed that dwarf_line_size is actually
preserved between the partial symbol scan and the full symbol read.
It isn't.

This patch should fix the following failures under -gdwarf-2:

FAIL: gdb.base/shlib-call.exp: (timeout) print shr1(g)
ERROR: Couldn't send break shr2 to GDB.
UNRESOLVED: gdb.base/shlib-call.exp: breakpoint function shr2
ERROR: Couldn't send continue to GDB.
UNRESOLVED: gdb.base/shlib-call.exp: run until breakpoint set at a function
FAIL: gdb.base/shlib-call.exp: (timeout) print shr1(1) 2nd time
FAIL: gdb.base/shlib-call.exp: (timeout) print mainshr1(1) from shlib func
FAIL: gdb.base/shlib-call.exp: step inside shr2 (shlib func) (timeout)
FAIL: gdb.base/shlib-call.exp: step out of shr2 to main (timeout)
FAIL: gdb.base/shlib-call.exp: (timeout) print mainshr1(1) from main
FAIL: gdb.base/shlib-call.exp: step into mainshr1 (timeout)


2002-05-09  Jim Blandy  <jimb@redhat.com>

	Properly track the size of the current objfile's .debug_line section.
	* dwarf2read.c (struct dwarf2_pinfo): New member: dwarf_line_size.
	(DWARF_LINE_SIZE): New macro.
	(dwarf2_build_psymtabs_hard): Record the line section's size in
	the partial symbol table.
	(psymtab_to_symtab_1): Restore dwarf_line_size from the partial
	symbol table.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.54.2.1
diff -c -c -b -F'^(' -r1.54.2.1 dwarf2read.c
*** dwarf2read.c	9 May 2002 20:03:36 -0000	1.54.2.1
--- dwarf2read.c	9 May 2002 23:24:22 -0000
***************
*** 434,439 ****
--- 434,443 ----
  
      char *dwarf_line_buffer;
  
+     /* Size of dwarf_line_buffer, in bytes.  */
+     
+     unsigned int dwarf_line_size;
+ 
      /* Pointer to start of dwarf string buffer for the objfile.  */
  
      char *dwarf_str_buffer;
***************
*** 458,463 ****
--- 462,468 ----
  #define DWARF_ABBREV_BUFFER(p) (PST_PRIVATE(p)->dwarf_abbrev_buffer)
  #define DWARF_ABBREV_SIZE(p) (PST_PRIVATE(p)->dwarf_abbrev_size)
  #define DWARF_LINE_BUFFER(p) (PST_PRIVATE(p)->dwarf_line_buffer)
+ #define DWARF_LINE_SIZE(p)   (PST_PRIVATE(p)->dwarf_line_size)
  #define DWARF_STR_BUFFER(p)  (PST_PRIVATE(p)->dwarf_str_buffer)
  #define DWARF_STR_SIZE(p)    (PST_PRIVATE(p)->dwarf_str_size)
  #define DWARF_MACINFO_BUFFER(p) (PST_PRIVATE(p)->dwarf_macinfo_buffer)
***************
*** 1222,1227 ****
--- 1227,1233 ----
        DWARF_ABBREV_BUFFER (pst) = dwarf_abbrev_buffer;
        DWARF_ABBREV_SIZE (pst) = dwarf_abbrev_size;
        DWARF_LINE_BUFFER (pst) = dwarf_line_buffer;
+       DWARF_LINE_SIZE (pst) = dwarf_line_size;
        DWARF_STR_BUFFER (pst) = dwarf_str_buffer;
        DWARF_STR_SIZE (pst) = dwarf_str_size;
        DWARF_MACINFO_BUFFER (pst) = dwarf_macinfo_buffer;
***************
*** 1525,1530 ****
--- 1531,1537 ----
    dwarf_abbrev_buffer = DWARF_ABBREV_BUFFER (pst);
    dwarf_abbrev_size = DWARF_ABBREV_SIZE (pst);
    dwarf_line_buffer = DWARF_LINE_BUFFER (pst);
+   dwarf_line_size = DWARF_LINE_SIZE (pst);
    dwarf_str_buffer = DWARF_STR_BUFFER (pst);
    dwarf_str_size = DWARF_STR_SIZE (pst);
    dwarf_macinfo_buffer = DWARF_MACINFO_BUFFER (pst);


             reply	other threads:[~2002-05-09 23:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-09 16:31 Jim Blandy [this message]
2002-05-09 20:08 ` Andrew Cagney
2002-05-09 20:45   ` Jim Blandy
2002-05-10 10:00 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020509233145.E23A45EA11@zwingli.cygnus.com \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox