From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8565 invoked by alias); 8 May 2002 21:20:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8511 invoked from network); 8 May 2002 21:20:21 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 8 May 2002 21:20:21 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 175YrE-0001Ac-00; Wed, 08 May 2002 17:20:20 -0400 Date: Wed, 08 May 2002 14:20:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Tom Tromey , gdb-patches@sources.redhat.com Subject: Re: Patch: printing java `char' values Message-ID: <20020508212020.GA4389@nevyn.them.org> Mail-Followup-To: Michael Snyder , Tom Tromey , gdb-patches@sources.redhat.com References: <877kmh8a6r.fsf@creche.redhat.com> <3CD8429E.DA6D6BC7@redhat.com> <873cx3vdhy.fsf@creche.redhat.com> <3CD9756D.F0AE4AF@redhat.com> <20020508194746.GA31548@nevyn.them.org> <878z6umkwn.fsf@creche.redhat.com> <20020508204626.GA2093@nevyn.them.org> <3CD99131.76E0B9BB@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CD99131.76E0B9BB@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-05/txt/msg00233.txt.bz2 On Wed, May 08, 2002 at 01:57:21PM -0700, Michael Snyder wrote: > I'd prefer not to perpetuate TYPE_CODE_CHAR. This seems to have been > a one-time thing, and not (I think) a good idea. In general if GDB > wants to know if two things can be added or XOR'd or something, it > only needs to check to see if they are TYPE_CODE_INT, (because chars > are really ints of size 1). This should have been implemented as a > TYPE_FLAG_*, not a TYPE_CODE-*. Sounds good to me. Would you be interested in patches which actually change TYPE_CODE_CHAR to TYPE_FLAG_CHAR, if it's practical? -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer