From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15161-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30085 invoked by alias); 8 May 2002 15:29:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30046 invoked from network); 8 May 2002 15:29:32 -0000
Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3)
  by sources.redhat.com with SMTP; 8 May 2002 15:29:32 -0000
Received: by fw-cam.cambridge.arm.com; id QAA04803; Wed, 8 May 2002 16:29:30 +0100 (BST)
Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5)
	id xma004213; Wed, 8 May 02 16:28:50 +0100
Received: from cam-mail2.cambridge.arm.com (cam-mail2.cambridge.arm.com [172.16.1.91])
	by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id QAA03193;
	Wed, 8 May 2002 16:28:50 +0100 (BST)
Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18])
	by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id QAA18424;
	Wed, 8 May 2002 16:28:50 +0100 (BST)
Message-Id: <200205081528.QAA18424@cam-mail2.cambridge.arm.com>
To: Michael Snyder <msnyder@cygnus.com>
cc: gdb-patches@sources.redhat.com, rearnsha@arm.com
Reply-To: Richard.Earnshaw@arm.com
Organization: ARM Ltd.
X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd)
X-Fax: +44 1223 400410
X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ.
X-Url: http://www.arm.com/
Subject: Re: [PATCH] Testing tweaks for xscale 
In-reply-to: Your message of "Fri, 03 May 2002 14:11:31 PDT."
             <200205032111.g43LBVJ27680@reddwarf.sfbay.redhat.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 08 May 2002 08:29:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
X-SW-Source: 2002-05/txt/msg00209.txt.bz2

> 2002-05-02  Michael Snyder  <msnyder@redhat.com>
> 
> 	* gdb.base/long_long.exp: Add xscale target.
> 	* gdb.base/default.exp: Add xscale target.
> 
> Index: gdb.base/default.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> retrieving revision 1.9
> diff -p -r1.9 default.exp
> *** gdb.base/default.exp	29 Mar 2002 01:19:11 -0000	1.9
> --- gdb.base/default.exp	3 May 2002 21:23:13 -0000
> *************** gdb_test "info files" "" "info files"
> *** 348,353 ****
> --- 348,355 ----
>   #test info float
>   if [istarget "arm*-*-*"] then {
>       gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
> + } elseif [istarget "xscale*-*-*"] then {
> +     gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
>   } elseif [istarget "thumb*-*-*"] then {
>       gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
>   } elseif [istarget "strongarm*-*-*"] then {
> Index: gdb.base/long_long.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/long_long.exp,v
> retrieving revision 1.7
> diff -p -r1.7 long_long.exp
> *** gdb.base/long_long.exp	17 Jul 2001 22:19:49 -0000	1.7
> --- gdb.base/long_long.exp	3 May 2002 21:23:13 -0000
> *************** if { $sizeof_double == 8 } {
> *** 157,162 ****
> --- 157,167 ----
>   #   assume the long long represents a floating point double in ARM format
>        gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*"
>   
> +   } elseif [ istarget "xscale*-*-*" ] then {
> + 
> + #   assume the long long represents a floating point double in ARM format
> +      gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*"
> + 
>     } else {
>   
>   #   assume the long long represents a floating point double in little

I'm assuming here that maintainership of the ARM parts includes changes 
like this to the testsuite...

Two points.

1) Since xscale is an ARM processor variant, I think these should be kept 
as a single "if" clause -- clearly we intend to do the same thing for both.

2) The following thumb clause is, I think, now dead -- thumb support has 
been rolled into the ARM configuration.

So I think the first change should be something like

   if {[istarget "arm*-*-*"] || [istarget "xscale*-*-*"] 
       || [istarget "strongarm*-*-*"]} then {
       gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info 
float"
   } else {.... non-arm things...

R.