From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14455 invoked by alias); 8 May 2002 01:30:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14444 invoked from network); 8 May 2002 01:30:47 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 8 May 2002 01:30:47 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 175GHx-0007jN-00; Tue, 07 May 2002 21:30:41 -0400 Date: Tue, 07 May 2002 18:30:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Tweak for a gdb.mi test. Message-ID: <20020508013041.GA29600@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com References: <200205080109.g4819B821604@reddwarf.sfbay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200205080109.g4819B821604@reddwarf.sfbay.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-05/txt/msg00190.txt.bz2 On Tue, May 07, 2002 at 06:09:11PM -0700, Michael Snyder wrote: > > I'm gonna ask for a second pair of eyes, since I don't know MI > very well. > > What this is -- the test is examining the stack, but it is > assuming that main is the last frame. My change allows for > one extra frame below main (eg. for '_start'). > > OK to check in? Before you check this in, I would prefer to have a policy decision in place about whether we should show that frame or not. The relevant macro is FRAME_CHAIN_VALID; I believe we should universally (or almost universally) change this to stop at main. I think that's func_frame_chain_valid but don't trust my memory. Some ports (HP/UX comes to mind) do wacky things in this macro/method. I'm not sure what they accomplish or whether they are really necessary. Most default to either file_ or func_, and we should standardize that unless there is a good reason not to. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer